Comments on: Adding Sorted Inserts to Cocoa Arrays http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/ Sharing Experience Sun, 12 Feb 2012 05:23:29 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Ben Lenarts http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/comment-page-1/#comment-55530 Ben Lenarts Mon, 06 Sep 2010 23:21:08 +0000 http://blog.jayway.com/?p=1441#comment-55530 Great work! I created a small repository on Github to hold a debugged version of the code: http://github.com/benlenarts/NSArray-CWSortedInsert Great work! I created a small repository on Github to hold a debugged version of the code: http://github.com/benlenarts/NSArray-CWSortedInsert

]]> By: Ilya Levin http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/comment-page-1/#comment-17051 Ilya Levin Mon, 30 Nov 2009 02:07:45 +0000 http://blog.jayway.com/?p=1441#comment-17051 Very nice addition, but you have a fatal bug. Your search should be compare (...) >0 instead of compare(...) < 0 for it to work, because NSOrderedAscending is returned when the second object is larger then the receiver, which means we need to the lower part of the search range, not the apper part (as long as the same comparison is used as the one used to sort the array) Very nice addition, but you have a fatal bug. Your search should be compare (…) >0 instead of compare(…) < 0 for it to work, because NSOrderedAscending is returned when the second object is larger then the receiver, which means we need to the lower part of the search range, not the apper part (as long as the same comparison is used as the one used to sort the array)

]]> By: Rikard Lindell http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/comment-page-1/#comment-14113 Rikard Lindell Thu, 22 Oct 2009 07:27:14 +0000 http://blog.jayway.com/?p=1441#comment-14113 Thank you for this very relevant article. It's a mystery why there is no SortedCollection counterpart in Cocoa/NextStep from the Smalltalk-80 environment, which so clearly have been the main inspiration for Objective-C. Cheers Rikard Thank you for this very relevant article. It’s a mystery why there is no SortedCollection counterpart in Cocoa/NextStep from the Smalltalk-80 environment, which so clearly have been the main inspiration for Objective-C.

Cheers
Rikard

]]> By: Fredrik Olsson http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/comment-page-1/#comment-2701 Fredrik Olsson Wed, 01 Apr 2009 07:01:11 +0000 http://blog.jayway.com/?p=1441#comment-2701 For the most common use cases you mentioned, you can use for example: <code>[myArray insertObject:myDate sortedUsingSelector:@selector(compare:)];</code>. As a rule of thumb; in Cocoa you should not make wrapper code to simplify something that is already a single statement. Making this even simpler by enforcing a single selector would also break the 1 to 1 feature mapping of the sort methods already available in the official Cocoa classes. For the most common use cases you mentioned, you can use for example: [myArray insertObject:myDate sortedUsingSelector:@selector(compare:)];.

As a rule of thumb; in Cocoa you should not make wrapper code to simplify something that is already a single statement. Making this even simpler by enforcing a single selector would also break the 1 to 1 feature mapping of the sort methods already available in the official Cocoa classes.

]]> By: Aaron VonderHaar http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/comment-page-1/#comment-2691 Aaron VonderHaar Tue, 31 Mar 2009 19:21:35 +0000 http://blog.jayway.com/?p=1441#comment-2691 It looks very useful, although personally I would want to see a simpler API for the most common cases: for instance, it would be nice to have a version of the sorted insert methods that don't require a sorting method to passes in, and would instead simply use the compare: selector. That way it would immediately work with NSNumber, NSString and NSDate, and you could support new objects easily by implementing compare: for those classes. Thanks for sharing the concept and the code! It looks very useful, although personally I would want to see a simpler API for the most common cases: for instance, it would be nice to have a version of the sorted insert methods that don’t require a sorting method to passes in, and would instead simply use the compare: selector. That way it would immediately work with NSNumber, NSString and NSDate, and you could support new objects easily by implementing compare: for those classes.

Thanks for sharing the concept and the code!

]]> By: Sorting NSArray at Under The Bridge http://blog.jayway.com/2009/03/28/adding-sorted-inserts-to-uimutablearray/comment-page-1/#comment-2670 Sorting NSArray at Under The Bridge Tue, 31 Mar 2009 05:44:46 +0000 http://blog.jayway.com/?p=1441#comment-2670 [...] an excellent article on how to do optimized NSArray sorting and NSMutable Array sorted inserts. NSArray admits to sorts [...] [...] an excellent article on how to do optimized NSArray sorting and NSMutable Array sorted inserts. NSArray admits to sorts [...]

]]>